search

jsonresume / resume-cli

CLI tool to easily setup a new resume 📑
https://jsonresume.org
MIT License
4.56k stars 386 forks source link

Themes are missing company names #620

Open kennedy opened 3 years ago

kennedy commented 3 years ago

I have tried numerous themes with a clean letter size pdf, but nearly all of them is unable to generate the company name.

node version: v14.17.2 Win10 21H1

{
    "jsonresume-theme-flat": "^0.3.7",
    "jsonresume-theme-onepage": "0.0.3",
    "jsonresume-theme-paper": "^0.5.0",
    "jsonresume-theme-rocketspacer": "^1.2.2",
    "resume-cli": "^3.0.5"
}

Attached are screen shots of the pages served through resume serve --theme [theme name]

onepage rocketspacer flat paper

sgowdev commented 3 years ago

I just noticed this today as well. I distinctly remember it working before, so this bug was recently introduced.

adewinter commented 3 years ago

Quick fix, in your resume.json you need to use name instead of company under your work entries. So for example:

  "work": [
    {
      "company": "Facebook",
      "startDate": "1999-03-10",
      "position": "Software Consulting",
      "summary": "Lorem ipsum software development and consulting."
    },
    ...

would become

  "work": [
    {
      "name": "Facebook",
      "startDate": "1999-03-10",
      "position": "Software Consulting",
      "summary": "Lorem ipsum software development and consulting."
    },
    ...

Here's the actual cause of the problem: the website schema uses "company" as the field name, while the actual schema definition uses "name". Not sure why there is a discrepancy, will try to put in a pull request to fix if I get the chance 🤷

adewinter commented 3 years ago

I think this should do the trick? Pull request

kennedy commented 3 years ago

Quick fix, in your resume.json you need to use name instead of company under your work entries.

hello @adewinter, yes I made sure the work object uses the name keyword instead of the company.

However, the opposite fixed the issue. For my setup, I changed the keyword from name to company. Now it works...????

Edit: reran

SethFalco commented 2 years ago

This is because it depends on the theme. A lot of themes unfortunately were made for an older version of the JSON Resume schema, so they haven't adopted the new name yet.

Later I'll see which ones are still accepting PRs and submit one to accept the new names for properties, and fallback to the old name.