search

jsonresume / resume-cli

CLI tool to easily setup a new resume 📑
https://jsonresume.org
MIT License
4.55k stars 379 forks source link

fix: add full theme path when using local themes on export #689

Closed Nezteb closed 2 years ago

Nezteb commented 2 years ago

Addresses https://github.com/jsonresume/resume-cli/issues/685 and potentially https://github.com/jsonresume/resume-cli/issues/408

Nezteb commented 2 years ago

FYI @rbardini @antialias

Nezteb commented 2 years ago

The lockfile changes are because I get this warning when running npm install:

npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

I'm on npm 8.1.0.

The husky folder is automatically added when I run npm install. If it shouldn't be there, I can add it to the .gitignore but for now I'm leaving it.

rbardini commented 2 years ago

The husky folder is automatically added when I run npm install. If it shouldn't be there, I can add it to the .gitignore but for now I'm leaving it.

husky@7.0.0 makes .husky/.gitignore unnecessary, but upgrading Husky is beyond the scope of this PR 🙂

LGTM!

Nezteb commented 2 years ago

@rbardini Is there anything else that needs to be done to get this merged? 😄

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 3.0.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rbardini commented 2 years ago

@Nezteb sorry for the delay, it's merged now. Thanks for your contribution ❤️