search

jsonresume / resume-cli

CLI tool to easily setup a new resume 📑
https://jsonresume.org
MIT License
4.55k stars 379 forks source link

fix(deps): bump puppeteer to `^16.1.0`, fix Apple Silicon installation #730

Closed tonypapousek closed 1 year ago

tonypapousek commented 2 years ago

This fixes chromium installation issues on Apple Silicon machines. Jest tests appear to pass, and I was able to render my personal resume.json to pdf on an M1 MacBook Pro after upgrading.

Note: I had to completely remove node_modules and run npm i again after bumping to get puppeteer to install chromium.

Users may have previously hacked their puppeteer installations via ~/.zshrc like so:

export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
export PUPPETEER_EXECUTABLE_PATH=`which chromium`

Those users may need to remove those two lines, start a new terminal emulator tab/instance, and re-install resume-cli to get the deps resolved.

tonypapousek commented 2 years ago

Whoops, looks like the M1 issue was already fixed in an unmerged PR: https://github.com/jsonresume/resume-cli/pull/612

@thomasdavis - Hate to pester, but can this PR (or something similar) be expedited for the arm64 folks?

dorupopacaliman commented 1 year ago

@rbardini Can we please merge this?

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket: