jsonresume / resume-schema

JSON-Schema is used here to define and validate our proposed resume json
http://jsonresume.org
MIT License
2.13k stars 278 forks source link

Inconsistency of "websites" vs. other collections #10

Closed thomasdavis closed 10 years ago

thomasdavis commented 10 years ago

"All collections are arrays except for websites. Does not look very consistent.

Edit: Also websites are under bio, also seems not very logical." - @zepplock https://github.com/jsonresume/resume-cli/issues/5

Moved this issue from the resume-cli tool, I agree, this part needs some rework.

opi commented 10 years ago

Moreover, "The value [..] will generally become the label" (https://github.com/jsonresume/resume-schema/blob/master/schema.json#L72) is not recommended to make resumes available in other languages than english, because of accents.

Proposal

website: [{
   name: string,
   url: string,
}],

(sorry for my miserable english)

thomasdavis commented 10 years ago

Good work guys, seems like we should stick to consistency and dynamic property names are pretty ugly when trying to theme. I was attempting to keep the specification less verbose but it's not worth the trade offs.

thomasdavis commented 10 years ago

I'm actually going to retract my opinion on what I did initially, and what is also proposed now.

Thinking about it further, you would generally just link to your homepage. For other projects you run, you will generally supply the url's under work, or projects.

e.g. I wouldn't link to cdnjs in my websites, it's linked in my work.

This will also make it easier on theme developers who will generally just list one site in your bio section.

The debate then changes to should it be homepage or website as a reference to your personal site/blog.

Want to push this one through pretty quickly so will need @wdoekes @opensourcegrrrl and @DandyDev

osg commented 10 years ago

+1 website On Jul 12, 2014 11:26 AM, "Thomas Davis" notifications@github.com wrote:

I'm actually going to retract my opinion on what I did initially, what is also proposed now.

Thinking about it further, you would generally just link to your homepage. For other projects you run, you will generally supply the url's under work, or projects.

e.g. I wouldn't link to cdnjs in my websites, it's linked in my work.

This will also make it easier on theme developers who will generally just list one site in your bio section.

The debate then changes to should it be homepage or website as a reference to your personal site/blog.

Want to push this one through pretty quickly so will need @wdoekes https://github.com/wdoekes @opensourcegrrrl https://github.com/opensourcegrrrl and @DandyDev https://github.com/DandyDev

— Reply to this email directly or view it on GitHub https://github.com/jsonresume/resume-schema/issues/10#issuecomment-48807836 .

DonDebonair commented 10 years ago

Agree with @thomasdavis and +1 on website

thomasdavis commented 10 years ago

Okay, issue marked as PR Needed

ocram commented 10 years ago

PR here if you want to make "website" a single string field: https://github.com/jsonresume/resume-schema/pull/101

DonDebonair commented 10 years ago

PR merged and changelog updated