search

jsonresume / resume-schema

JSON-Schema is used here to define and validate our proposed resume json
http://jsonresume.org
MIT License
2.1k stars 278 forks source link

question: about ResumeToPDF #439

Open vikramsoni2 opened 2 years ago

vikramsoni2 commented 2 years ago

I just noticed that the ResumeToPDF repo has been archived. How are you guys planning to provide the pdf version of the resume if needed to be printed?

I am curious as I would like to include small autogenerated QR code when you print the resume. Only provide this QR code for print style which points to the registry.jsonresume.org to your resume. What are your thoughts?

SethFalco commented 2 years ago

I wasn't around at the time, but I assume it was archived because it wasn't used in this repo.

We can see here that they just run it through a browser and call print.

I haven't tested this, but I'm betting if your theme just used a media query for print and set the QR code to visible, it'd work just fine.

More info: https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries#targeting_media_types

vikramsoni2 commented 2 years ago

I see the point. Its easier to just use the browser's native print to pdf function. About the QR code, my question was not how to add QR code, but more like would you like a pull request to automatically generate and provide qr code for the resumes generated from registry ?

nricardo commented 1 year ago

Hi all,

I agree that's easier to just use the print on the browser and save it as PDF, but in reality you get something that's far optimised for the purpose. There's still very little support for CSS Paged Media (@page). Take a look at https://developer.mozilla.org/en-US/docs/Web/CSS/@page#browser_compatibility and https://caniuse.com/css-paged-media. That being said, it would be great to have support to create our resume with quality output for PDFs. I had to struggle quite some time to make page breaks work with decent outcome and also keep the background flow when that happens. BTW: good idea for the QR code... will put that one for sure in my own CV.

rvdwegen commented 1 year ago

For anyone interested in this functionality you can also use the HTML to PDF action from fifsky. https://github.com/marketplace/actions/html-to-pdf

DustinWehr commented 1 year ago

@rvdwegen is there any way for me to very quickly see how well the action will work for my resume, if I've never used github actions? I'm willing to take the time to learn github actions, but only if I know it'll work for my current resume (with, say, at most a few hours tinkering with my html/css). Maybe I could pass you some bucks in exchange for running my html resume through your setup and showing me the results? dustin-wehr-resume.html

rvdwegen commented 1 year ago

@DustinWehr open up in chrome and print to A4 PDF, that should be pretty much what you get.