search

jsonresume / resume-schema

JSON-Schema is used here to define and validate our proposed resume json
http://jsonresume.org
MIT License
2.15k stars 278 forks source link

Custom avatar is not loaded into the JSON resume (Elegant theme) #469

Closed lananolana closed 1 year ago

lananolana commented 1 year ago

Description

The default image is displayed in place of the avatar instead of the actual image that is added into the resume.json file. The problem is only in the Elegant theme.

Steps

Preconditions: JSON resume with Elegant theme is uploaded as a gist without an image link.

  1. Copy the avatar URL, for example my GitHub avatar
  2. Paste the URL into resume.json file and update the public gist.
  3. Refresh the resume page (https://registry.jsonresume.org/{your_github_username})

Actual result

The default image is displayed in place of the avatar.

Image URL in the resume.json:

Actual link

Actual image URL on the page:

Error link

Expected result

The picture whose link is added to the resume.json file is displayed in place of the avatar.

Additional links

IodizedSalt commented 1 year ago

I've had the same issue with the same theme. Switching to other themes resolved the issue, but I still wish to use Elegant as it is simply better than the others I have found.

lananolana commented 1 year ago

I've had the same issue with the same theme. Switching to other themes resolved the issue, but I still wish to use Elegant as it is simply better than the others I have found.

Thanks for the detail, I've added it to the issue.

thomasdavis commented 1 year ago

Thanks for the issue @lananolana

Though, the theme developers have control over the rendering.

Consider creating an issue at https://github.com/mudassir0909/jsonresume-theme-elegant