search

jsonresume / resume-schema

JSON-Schema is used here to define and validate our proposed resume json
http://jsonresume.org
MIT License
2.12k stars 277 forks source link

`meta.canonical` in `sample.resume.json` is 404 #470

Open etu opened 1 year ago

etu commented 1 year ago

In the 1.0.0 release of the file sample.resume.json the value meta.canonical points to a path that is now 404.

See this file: https://github.com/jsonresume/resume-schema/blob/7095651fbbb593d2c5dc2db3095412b170d74d2e/sample.resume.json It points to: https://raw.githubusercontent.com/jsonresume/resume-schema/master/resume.json

This should probably point to: https://raw.githubusercontent.com/jsonresume/resume-schema/master/schema.json

On master it points to: https://raw.githubusercontent.com/jsonresume/resume-schema/master/sample.resume.json which probably is wrong as well.

This came up to me in the issue here https://github.com/TaserudConsulting/jsonresume-nix/pull/3 because I got bad URL's from resumed which is an issue that I've reported here: https://github.com/rbardini/resumed/issues/8

However, this library would need a new release that addresses this so resumed can update and actually provide the correct path in it's sample.

rbardini commented 1 year ago

$schema seems to point to the correct (versioned) URL. The file on master is the latest schema, which may not match the published one.

meta.canonical points to a valid file on master, but like $schema, I think it should point to a versioned URL. Opened #472 fixing that.

Either way, we need a new release to fix the broken resume.json reference—and the versions in sample.resume.json must be updated beforehand to match the new release version.

thomasdavis commented 3 months ago

Hi guys, I've merged @rbardini changes (thank you) and I've pushed a new version of resume-schema@1.0.1

I've always decided to do things differently going fourth

The current working version of the schema is `v1.0.0` that is represented by the `master` branch and the files `schema.json` and `sample.resume.json`.

Such that master shall always be the most stable newest version. And develop will be used for working on new versions going fourth.

I'm also probably going to change the package name to @jsonresume/schema

edit: i did change the package name to @jsonresume/schema (well pushed a new one, old one still works but will be forever stuck at v1 schema)