Closed jayzalowitz closed 10 years ago
{
"profiles": [
{
"name": "twitter",
"username": "neutralthoughts"
},
{
"name": "facebook",
"url": "https://www.facebook.com/1231453342"
},
{
"name": "soundcloud",
"url": "https://soundcloud.com/dandymusicnl",
"username": "dandymusicnl"
},
]
}
Good work guys, let's lock down as above. Label applied for PR Needed
Wait, I don't want to throw a wrench in things, but is "name" the right field label? Would "type" be more appropriate? Only reason I say this is I could imagine people getting confused by "name" and thinking it means the name of person's profile that is being referenced.
I know you wouldn't do this, but it could follow logically that either of these could be possible, when iterating through profiles:
{ "name": "twitter", "username": "neutralthoughts" }
Vocalized: "This profile's username is 'neutralthoughts'. It's name is 'twitter'."
{ "type": "twitter", "username": "neutralthoughts", "name": "Thomas Davis" }
Vocalized: "This profile's username is 'neutralthoughts'. It is of type 'twitter' and the name is 'Thomas Davis'.'"
Just a thought.
Agreed, how about network
?
On Wed, Jul 16, 2014 at 8:19 PM, Ryan Shea notifications@github.com wrote:
Wait, I don't want to throw a wrench in things, but is "name" the right field label? Would "type" be more appropriate? Only reason I say this is I could imagine people getting confused by "name" and thinking it means the name of person's profile that is being referenced.
I know you wouldn't do this, but it could follow logically that either of these could be possible, when iterating through profiles:
{ "name": "twitter", "username": "neutralthoughts" }
Vocalized: "This profile's username is 'neutralthoughts'. It's name is 'twitter'."
{ "type": "twitter", "username": "neutralthoughts", "name": "Thomas Davis" }
Vocalized: "This profile's username is 'neutralthoughts'. It is of type 'twitter' and the name is 'Thomas Davis'.'"
Just a thought.
— Reply to this email directly or view it on GitHub https://github.com/jsonresume/resume-schema/issues/6#issuecomment-49146508 .
Thomas Davis http://thomasdav.is
VP of Tech - Earbits - http://earbits.com Co-founder - Cdnjs - http://cdnjs.com Founder - Backbone Tutorials - http://backbonetutorials.com
+1 for network
I realise that might not be entirely accurate for stuff like Skype, but I still think we should roll with it.
I like network
, maybe service
as an alternative? Both are better than name
in my opinion. Good remark, @rxl!
Alright, lock in network
for the PR
A bit late, and for the record, +1 for 'network', as in social network. On Jul 16, 2014 12:20 PM, "Thomas Davis" notifications@github.com wrote:
Agreed, how about
network
?On Wed, Jul 16, 2014 at 8:19 PM, Ryan Shea notifications@github.com wrote:
Wait, I don't want to throw a wrench in things, but is "name" the right field label? Would "type" be more appropriate? Only reason I say this is I could imagine people getting confused by "name" and thinking it means the name of person's profile that is being referenced.
I know you wouldn't do this, but it could follow logically that either of these could be possible, when iterating through profiles:
{ "name": "twitter", "username": "neutralthoughts" }
Vocalized: "This profile's username is 'neutralthoughts'. It's name is 'twitter'."
{ "type": "twitter", "username": "neutralthoughts", "name": "Thomas Davis" }
Vocalized: "This profile's username is 'neutralthoughts'. It is of type 'twitter' and the name is 'Thomas Davis'.'"
Just a thought.
— Reply to this email directly or view it on GitHub < https://github.com/jsonresume/resume-schema/issues/6#issuecomment-49146508>
.
Thomas Davis http://thomasdav.is
VP of Tech - Earbits - http://earbits.com Co-founder - Cdnjs - http://cdnjs.com Founder - Backbone Tutorials - http://backbonetutorials.com
— Reply to this email directly or view it on GitHub https://github.com/jsonresume/resume-schema/issues/6#issuecomment-49146588 .
Gj everybody
Take it from me, unless you have a handle/id (ex FBid)/standardurl setup its going to lead to issues.