search

jsonresume / theme-manager

Theme server for JSON Resume
MIT License
166 stars 31 forks source link

Should the default resume.json be read everytime a request is made to the server ? #1

Closed anthonyray closed 10 years ago

anthonyray commented 10 years ago

Maybe we should read the content of the resume.json file once and for all at the initialisation of the server. This solution causes a problem if the resume.json is modified though (I think that won't happen often)

erming commented 10 years ago

Here's a solution: https://github.com/erming/jsonresume-theme-flat/blob/master/serve.js#L10

This should keep it up to date with the latest defaults, too.

thomasdavis commented 10 years ago

I think he means the actual server code. I saw that you wrapped into an async call at least, but ideally it should just be loaded into ram at the top of the file, I was just rushing.

On Thu, Jul 10, 2014 at 10:02 AM, Mattias Erming notifications@github.com wrote:

Here's a solution: https://github.com/erming/jsonresume-theme-flat/blob/master/serve.js#L10

This should keep it up to date with the latest defaults, too.

— Reply to this email directly or view it on GitHub https://github.com/jsonresume/theme-manager/issues/1#issuecomment-48550749 .

Thomas Davis http://thomasdav.is

VP of Tech - Earbits - http://earbits.com Co-founder - Cdnjs - http://cdnjs.com Founder - Backbone Tutorials - http://backbonetutorials.com