jsonresume / theme-manager

Theme server for JSON Resume
MIT License
166 stars 31 forks source link

Theme names should not be case-sensitive #13

Closed dbkaplun closed 8 years ago

PeterDaveHello commented 10 years ago

Why? case-sensitive won't bite.

poleveD commented 9 years ago

@secrettriangle if you are referring to the theme name in the URL, I have created a pull request with a fix for the same.

mchelen commented 9 years ago

For reference, uppercase is not allowed in NPM package names https://github.com/npm/npm-www/pull/410#issuecomment-27717029

poleveD commented 9 years ago

@mchelen yes, that is correct. We cannot have those using jsonresume to provide the theme names in small case letters, simply because they do not or need not care where the server is running or what/how it shows the ouput.

Thoughts?

thomasdavis commented 8 years ago

If NPM does not allow uppercase published theme names, then this will never been an issue for us.