jsonresume / theme-manager

Theme server for JSON Resume
MIT License
166 stars 31 forks source link

Theme error #14

Open TimDaub opened 10 years ago

TimDaub commented 10 years ago

Hi,

I just published my json-resume-theme here: https://www.npmjs.org/package/jsonresume-theme-paper

Unfortunately I get an error: http://themes.jsonresume.org/theme/paper

Is this a problem with my theme or your server?

thomasdavis commented 10 years ago

Hi Tim. I will look into this in morning.

thomasdavis commented 10 years ago

It's more a problem with your theme at the moment, but it shouldn't be(Our server should be flexible as possible)

At the moment I have a feeling that it is the use of Bower that is the problem.

thomasdavis commented 10 years ago

So the first error I encountered, was that merrirweather font isn't in your bower.json.

Second error is that the themes server doesn't install bower components just yet. I might try do now, otherwise updating your theme to use static assets will work in the mean time or remove bower_components from .gitignore and just commit the bower install output.

thomasdavis commented 10 years ago

Thirdly, your theme looks awesome!

thomasdavis commented 10 years ago

I committed the bower components and tested it out by publishing to npm. http://registry.jsonresume.org/thomasdavis?theme=paper-fixed

It works, so if you want to commit them on your official package until I get bower installing on the themes server that would be great.

TimDaub commented 10 years ago

Hi there,

I fiddled around a little bit but it seems like bower integration doesn't quite work yet, doesn't it? I managed to get the theme up by publishing my bower_components with the package.

As I already said in the email: Once I include merriweather locally the typefaces are weirdly mixed. Don't know if this has something to do with the file format I'm using but I guess I have to figure that out on my own.

So how can we push this further? Do you first need to fix this on the server or is there something I can do?

erming commented 10 years ago

Thirdly, your theme looks awesome!

I second that!

thomasdavis commented 10 years ago

Added to themes page -> https://jsonresume.org/themes/