search

jsonsystems / json-schema

JSONSchema.Net Public Repository
Apache License 2.0
663 stars 64 forks source link

Long string patterns expand width of entire viewport #10

Closed hackel closed 6 years ago

hackel commented 6 years ago

When entering a very long string pattern, it expands the viewport beyond the browser width, requiring scrolling back and forth. The overflow should be hidden when not actively editing the field to avoid this. I suspect all the fields probably have this same issue, but I haven't encountered it yet.

jackwootton commented 6 years ago

Thanks for reporting this. Could you provide a screenshot and I 'll get on with fixing this.

hackel commented 6 years ago

image

Hopefully this illustrates the issue. I just noticed that there are actually two problems. The most critical (to me) is that it expands the viewport, requiring horizontal scrolling (note it's scrolled all the way to the right in the screenshot). The other minor issue is that the pattern is extending outside of the grey box surrounding it. It's also wrapped to the next line.

What I would like to see is simply `"pattern": "^([+-]?\d{4}(?!\d{2}\b))..." to indicate that it is longer and cut off, so that when I am done editing this field, I will still be able to see and click on the required checkbox for other fields, instead of having it pushed out of the window. Hopefully that rambling made sense!

jackwootton commented 6 years ago

This should be available in the next 4 weeks. A few other features were implemented in parallel - which is pushing out the deadline. This is already implemented in a local and staging environment. Soon to be released.

Thanks for your patience.

jackwootton commented 6 years ago

This is now fixed and deployed on https://www.jsonschema.net