jsontypedef / json-typedef-codegen

A CLI tool that generates code from JSON Typedef schemas

https://jsontypedef.com/docs/tools/jtd-codegen

MIT License

160 stars 31 forks source link

Rust: Fixing Dockerfile and Cargo.toml for test cases #58

Open niko-dunixi opened 2 years ago

niko-dunixi commented 2 years ago

This solves issue: https://github.com/jsontypedef/json-typedef-codegen/issues/57

Solution

I've pinned the dependencies at a version that works today and sets the tested Rust version to one that is also current.

Extra Credit

I've also added docker buildkit into the mix so the cargo dependencies are shared across each of the test-cases and saves some testing time. I don't know if there is any CI/CD in place already, but if the Docker version running is current this should be non-breaking

niko-dunixi commented 2 years ago

I didn't realize that there was a requirement for commits to be signed. I've setup GPG and then rebased my branch to resign all the commits before force-pushing to update this PR.

ryanatallah commented 1 year ago

@ucarion would you mind reviewing this change? It seems that there are a few improvements which are blocked by test failures.

niko-dunixi commented 1 year ago

@ucarion My apologies for any inconvenience, but I didn't realize when I revoked my older GPG key that it actually unverified my previous commits. I've re-signed them.