jsopn / vrc-lyrics

Display the track and its lyrics in a VRChat's chatbox using the OSC
MIT License
8 stars 1 forks source link

Feature Request - Only send updates when needed. #10

Open AvocadoVR opened 1 year ago

AvocadoVR commented 1 year ago

I would like it to update for when I change the song or there is a new lyric that it needs to push. Not updating every 800 spams console and osc.

There should be two modes.

Update & Update on Song Change & New Lyric.

Updating every so often causes to much spam. It can spam the osc way to much more then what it needs to be called.

AvocadoVR commented 1 year ago

Note: Do to this is its a bit unusuable. As it spams to much it timeouts in vrchat and it gets stuck on old lyrics.

But even with update mode It will still cause osc spam. I think its like no more than 5 messages within 5 seconds.

jsopn commented 1 year ago

image

For now, while this issue is not complete, you can tweak one of this settings, and set it to value you like.

AvocadoVR commented 1 year ago

image

For now, while this issue is not complete, you can tweak one of this settings, and set it to value you like.

It I touch that wouldn't that just decrease how often it updates lyrics?

jsopn commented 1 year ago

image For now, while this issue is not complete, you can tweak one of this settings, and set it to value you like.

It I touch that wouldn't that just decrease how often it updates lyrics?

You can decrease a RateLimit variable and it will be fine

AvocadoVR commented 1 year ago

image For now, while this issue is not complete, you can tweak one of this settings, and set it to value you like.

It I touch that wouldn't that just decrease how often it updates lyrics?

You can decrease a RateLimit variable and it will be fine

Yeah. But As I suspected the is going to offset lyrics for songs unless you spam it.

AvocadoVR commented 11 months ago

Just want to get an update is the a plan time when this be released.

jsopn commented 11 months ago

Just want to get an update is the a plan time when this be released.

I will try to complete all the planned updates before the end of the month, I unfortunately have a lot of personal stuff going on right now, so I don't have time to get everything done fast enough

AvocadoVR commented 11 months ago

That's fine.