search

jsor / jcarousel

Riding carousels with jQuery.
https://sorgalla.com/jcarousel/
MIT License
1.99k stars 736 forks source link

AMD friendly #612

Closed szepeviktor closed 10 years ago

szepeviktor commented 10 years ago

Please consider making jcarousel AMD friendly. Yes, I've read https://github.com/jsor/jcarousel/issues/410

And I know jQuery plugins communicate by a global. But here is a nice biolerplate: https://github.com/umdjs/umd

High quality websites use AMD loader (like curl.js). Thank you!

neonwired commented 10 years ago

Still doesn't work with require.js

It's pretty disappointing as I've always found this plugin useful, now i'll have to find a alternative.

szepeviktor commented 10 years ago

@neonwired If you need it you can wrap the jcarousel and all four plugins into this: https://github.com/umdjs/umd/blob/master/jqueryPlugin.js (and optionally make them dependent on jcarousel)

jsor commented 10 years ago

I'm not totally against AMD support now. So, if anyone is interested, feel free to make a PR.