search

jsor / jcarousel

Riding carousels with jQuery.
https://sorgalla.com/jcarousel/
MIT License
1.99k stars 736 forks source link

jQuery 1.8.x and CSS transition support #676

Closed robations closed 10 years ago

robations commented 10 years ago

I couldn't get the CSS transitions to work with jQuery 1.8.x.

I traced the problem as far as line 643 in /dist/jquery.jcarousel.js. The script seems to error out at this point because it is passing a jQuery object backup into the css() method. After bumping the jQuery version up to 1.9 the problem disappeared.

Now I look at the jQuery docs, I see that array argument style was introduced with jQuery 1.9, so either you'd want to rewrite this, put a caveat in the docs against using transitions, or change the version constraints in bower.js etc...

jsor commented 10 years ago

Thanks for the report. It's fixed now.