search

jsor / jcarousel

Riding carousels with jQuery.
https://sorgalla.com/jcarousel/
MIT License
1.99k stars 736 forks source link

Ensure event handlers are triggered, not DOM functions #701

Closed michaelward82 closed 10 years ago

michaelward82 commented 10 years ago

Chrome 36 introduces a change that adds an event.animate() function to the DOM. The jQuery trigger() function will execute functions and not event handlers where a naming clash exists.

Changing the code to use the jQuery triggerHandler() function rather than trigger() ensures that event handlers are always fired as intended.

michaelward82 commented 10 years ago

This fix may prove too simplistic due to the differences between trigger() and triggerHandler(). Should it prove so then I will investigate further ideas.

jsor commented 10 years ago

Can you explain that with a use case? Since every event is prefixed with a namespace (jcarousel:, jcarouselcontrol: etc.), i don't think there will be name clashes.

michaelward82 commented 10 years ago

I'll double check that I'm using the latest build, and confirm the problem is affecting me. I'm having problems in Chrome 36.

michaelward82 commented 10 years ago

After some extensive testing, making sure I was using the correct and latest build, I humbly withdraw PR#701 :)