search

jsor / jcarousel

Riding carousels with jQuery.
https://sorgalla.com/jcarousel/
MIT License
1.99k stars 736 forks source link

jquery 3.0 #800

Closed ghost closed 8 years ago

ghost commented 8 years ago

I'm getting: carousel.js:16 Uncaught TypeError: this.clip.size is not a function in my event log.

jsor commented 8 years ago

Which version are you using? The current 0.3.x or the older 0.2.x?

ghost commented 8 years ago

Jquery 3.0 beta 1. The problem is size() function which is deprecated. I solve problem by myself. size() > length (length is supported by jquery 1.0 >) I rewrite the code. (https://jsfiddle.net/Lwx1h8aq/) - here is, minified version. (working with 3.0.x) I write to you, to fix this problem for all other users which using this pretty carousel :)

ghost commented 8 years ago

aww.. about the carousel version, i don't know, maybe 0.2.x.. Look at jsfiddle.

jsor commented 8 years ago

Sorry for the delay. I've released 0.2.10 which should fix this.

AbdealiLoKo commented 8 years ago

Guess this can be closed then ?

ghost commented 8 years ago

yep :)

jsor commented 8 years ago

@val4o0o0 Then feel free to close when your issue has been resolved :)