search

jsor / lity

Lightweight, accessible and responsive lightbox.
https://sorgalla.com/lity/
MIT License
1.16k stars 196 forks source link

Lity stopped working for YouTube videos #245

Open dmitry1704 opened 4 years ago

dmitry1704 commented 4 years ago

Hi,

For some reason, Lity has stopped working with YouTube videos. Ex: https://rsaa.anu.edu.au/public/movies-public-lectures

We have experienced this issue across different university sites. Not sure if the issue is related to some update by YouTube.

Thank you, Dima

wakkoism commented 4 years ago

This seems to be related to jQuery update done on Drupal 7.70. I haven't found a solution yet.

wakkoism commented 4 years ago

@dmitry1704 , I figured out the issue, I've created a patch to fix this PR - https://github.com/jsor/lity/pull/246/files Basically there the new update on Drupal runs through htmlprefilter which then is passed into jQuery.clean, and gets removed because there is no self closing iframe tag.

dmitry1704 commented 4 years ago

Wow @wakkoism , thank you so much for finding the issue in Drupal and sharing the patch. I'm testing it and it works.

pdomingos commented 4 years ago

@wakkoism , thank you! We've also had this problem in a Drupal 7.72 installation and closing the