Next release 2.4.0 or 3.0.0

jsoverson / preprocess

Preprocess HTML, JavaScript, and other files with directives based off custom or ENV configuration

Other

366 stars 80 forks source link

Next release 2.4.0 or 3.0.0 #67

Closed BendingBender closed 9 years ago

BendingBender commented 9 years ago

@Frizi and @orionstein, I'd like to release the next version soon. However, I'm looking at the changelog and I have doubts as which version number I should give this release.

There are a number of changes that might subtly break existing setups (like hidden blocks and coffescript extensions). All in all I'm in doubt of whether to call it 2.4.0 or 3.0.0 .

What do you guys think?

armandabric commented 9 years ago

Semver said: breaking change = new major :)

BendingBender commented 9 years ago

Yeah I know. In an ideal world, the changes that were introduced this time are not breaking. Each of them is an extension and if something breaks, then that's a bug. In an ideal world...

Now that I think of it, the new EOL handling might actually impose a breaking change. Any thoughts?

armandabric commented 9 years ago

Yes it's enough to justify a major I think. With in addition all the other change, this not a bad idea to go on a new major release.

BendingBender commented 9 years ago

Well, just to be sure that no production systems break, I'll release it as 3.0.0. There were just too many changes to be sure that they were not breaking.

Frizi commented 9 years ago

What about writing some more tests before actual release? I'm not convinced right now that everything works as expected and as fast as expected. Things might have slow down due to a lot more going on with block statements or a little bit more dynamic regex compilation.

I'm currently running it in quite large environment and see considerable compile time variation across different files. Don't have much time to pinpoint the issue on live code though.

BendingBender commented 9 years ago

Yes, before the 3.0.0 release, I'd like to at least accomplish following tasks:

port the test suite to mocha
add some test coverage framework
change the srcDir context attribute to be optional and default it to cwd
make the lib throw an error if a file that has to be included/extended can not be found along with some option on the context to opt in to not throwing an error in such case (would fix #35)
optionally cache created RegExp objects so that they don't have to be recompiled on each recursive invocation (need to measure performance here to see if it's worth the effort)