search

jsoverson / refactor-plugin-common

Apache License 2.0
4 stars 3 forks source link

Relationship with shapesecurity/unminify #1

Open re-engineer opened 4 years ago

re-engineer commented 4 years ago

Hello, I was wondering what the end-goal for these plugins is meant to be, especially given the other set of util functions for refactoring Shift ASTs in shapesecurity/unminify. Is this library and its plugins meant to replace the functionality of unminify, or just to act as a tool for more fine control of AST manipulation? Do you plan to expose certain transforms from unminify in this, as they are basically equivalent to common util methods?

Apologies for the long message; I just appreciate shift-refactor and am curious about its future and how it will affect the structure of my programs using it.

jsoverson commented 4 years ago

Unminify came first and proved out some concepts. Shift-refactor is a personal project that started with unminify as a dependency but grew to sit on its own to experiment with a different API for generic AST transformation.

I moved out the "common" and "unsafe" methods once refactor became more generic and I need to revisit them. Uniminify's transformations are probably much safer and more correct so I will use them as a guide for mine.