jspahrsummers / adt

Algebraic data types for Python (experimental, not actively maintained)
MIT License
172 stars 14 forks source link

Small improvements #27

Closed wchresta closed 4 years ago

wchresta commented 4 years ago

This merge request contains three small improvements:

While testing I found some issues with the mypy plugin. I created the test cases but deactivated them.

The unit test for the README code could probably be refactored into re-using the code in the README. I'm probably not going to get to it for a while, so I might just remove the README unit-test if you consider this to be a blocker. We can add it later when I (or someone else) has time.

If you don't like the idea of the issue-style unit-tests, I can create a merge request just for the README fix, instead.

jspahrsummers commented 4 years ago

Thank you, this pull request is incredible! 🌟