search

jspahrsummers / adt

Algebraic data types for Python (experimental, not actively maintained)
MIT License
172 stars 14 forks source link

Add __hash__ #44

Closed stephenmell closed 3 years ago

stephenmell commented 3 years ago

This adds an implementation of hash, fixing bug #32. The hash is that of the pair containing _key and _value.

jspahrsummers commented 3 years ago

Thank you very much for the pull request! The implementation looks great. ✨

Any chance you would be willing to add a quick unit test, so that we can be sure this works now and into the future? :pray:

stephenmell commented 3 years ago

Sorry for the delay. I've added a unit test which fails without the change and succeeds with it.

I just noticed the comment about how this project isn't actively maintained, which is a shame, since I've found it very useful. Do you expect to still be merging pull requests, or are you looking to hand it off?

jspahrsummers commented 3 years ago

Thanks for the test! :bow:

I just noticed the comment about how this project isn't actively maintained, which is a shame, since I've found it very useful. Do you expect to still be merging pull requests, or are you looking to hand it off?

I am still reviewing and merging pull requests (though not always very promptly). The main reason I'm not more active with the project is that I'm not working on anything where I'm actually using it.

I'm happy to direct people to a more active fork, if there is or would be one. 🤷