search

jspargo / dependabot-core

🤖 The core logic behind Dependabot's update PR creation
https://dependabot.com
MIT License
0 stars 2 forks source link

Test fixes & WIP writing of new Podfile #1

Closed RuudPuts closed 4 years ago

RuudPuts commented 4 years ago

Hi! Saw your PR on dependabot/dependabot-core and wanted to help out.

This PR fixes all tests in meta_data_finder and requirements_updater, I've started on file_updater_spec but am not familiar enough yet on the code to figure it out.

After that started running the dry-run script and made it somewhat functional. There's something not working smoothly with the regexes defined in file_updater. The POD_CALL regex doesn't match anything the way it's currently executed. Reason I found for this are newlines in the regex, even though /x is passed to allow those additional whitespaces. Printing the POD_CALL regex in runtime, manually replacing all newlines does yeild results when I test agains this podfile.

For now this is it, I am planning on continuing these fixes so hopefully we can get your PR on dependabot/dependabot-core merged.

jspargo commented 4 years ago

@RuudPuts this is so helpful - thank you so much for your help on this!

OK, first confession - I thought I'd better rebase my branch off https://github.com/dependabot/dependabot-core and it seems to have introduced a bunch of conflicts on this PR - sorry! Happy to help you resolve them, but if between us we can resolve those I'll take a proper look at this PR early this week.

I'm wracking my brains to remember exactly where I got to with this, but I do recall that the regex was an issue, so fingers crossed we can get that sorted.

I'll also start chipping away at this too and set up CI on this fork too so it's easier for the both of us to get this branch in a good place.

Thanks again - this is so great!

jspargo commented 4 years ago

OK, I moved the content of this PR into #2. Sorry for the git mess I caused in this PR - didn't realise how out of date my add-cocoapods had got 😅

RuudPuts commented 4 years ago

No problem at all! I could've warned you as I tried to do the same thing haha! Merging in master wasn't that big of an issue though :) I'll check out #2!