search

jspargo / dependabot-core

🤖 The core logic behind Dependabot's update PR creation
https://dependabot.com
MIT License
0 stars 2 forks source link

Test fixes & WIP writing of new Podfile #2

Closed jspargo closed 4 years ago

jspargo commented 4 years ago

Re-raising after I messed up the PR by rebasing add-cocapods. See #1 for full details - I've cherry picked your commits @RuudPuts

jspargo commented 4 years ago

Hey @RuudPuts - once again, sorry for messing up your original PR #1 with my overenthusiastic rebasing 🤦‍♂

Thanks for your contribution - I've added CI to my fork of dependabot-core to make things easier. I'll merge this in if you're happy with it?

Please do feel free to keep chipping away at this with PRs into this fork so we can get https://github.com/dependabot/dependabot-core/pull/731 passing and ready to merge 🎉

RuudPuts commented 4 years ago

Awesome addition of Cirlce! I was thinking of doing something similar with Github Actions but this'll do just fine!

We might want to disable tests which are currently failing until we fix them? Then at least this PR can get into the PR on dependabot/dependabot-core and piece by piece the rest can be fixed.

Over the weekend I probably have some more time to work on this a bit more.

jspargo commented 4 years ago

Hey @RuudPuts - just an update of where I've got to with this: I couldn't get the tests passing across the board, but tested out the two dry-runs that you mentioned and it looks like we're getting close!

For some reason the tests that I was having issues with (18 in total in the cocoapods directory) were hanging for me, rather than failing, which is weird. Were you able to get them to pass locally for you?

I've set them to pending for now, and I think if they pass CI here then I'll merge this into add-cocoapds as it's good progress, but perhaps between the two of us we can get them re-enabled, and hopefully in the process get it into a state where it's working correctly for a variety of repositories with Podfiles 🎉

RuudPuts commented 4 years ago

@jspargo I've also seen the hanging, rather than directly failing, tests. When I used ctrl + c it did print the stack trace & error though, so I was able to fix them locally and after then they seemed to run fine.

I noticed the disabling of tests and ran again locally, also after clearing the cache in ~/.cocoapods. Oddly enough all 94 still succeeded, with the 4 pre-existing pending tests. I'm sure we can get them to succeed everywhere!

On the dry-run, I've investigated the failure in the repository I mentioned and it turned out to be a regex issue. This is fixed in #4. Maybe you can create some issues for work you think is left other than fixing the tests & testing on more repo's? For example I'm not sure what to do with the 4 tests which where already disabled.

Awesome that you've merged this, great to see the changes show up in https://github.com/dependabot/dependabot-core/pull/731!