search

jspargo / dependabot-core

🤖 The core logic behind Dependabot's update PR creation
https://dependabot.com
MIT License
0 stars 2 forks source link

Add missing fixtures for update_checker_spec #3

Closed RuudPuts closed 4 years ago

RuudPuts commented 4 years ago

I've added all missing fixtures to make update_checker_spec run, but test are not succeeding yet. We could empty out most of the all_pods_version_*.txt files (they'll still be requested by cocoapods) except for where Nimble, Alamofire and AlamofireImages are defined.

RuudPuts commented 4 years ago

I've just realised this PR broke quite a few things. Also hadn't noticed the already existing spec files in fixtures/cocoapods/podspecs so I'll make sure to clean that up.

Let's consider this WIP for now

RuudPuts commented 4 years ago

@jspargo Worked a bit more on this one, got this very nice result out of it

$ bundle exec rspec spec

Randomized with seed 45988
...........................................***..*.............................................

Finished in 11.22 seconds (files took 1.19 seconds to load)
94 examples, 0 failures, 4 pending

Randomized with seed 45988

Testing the dry-run with a simple Podfile works just fine, you can try this by running $ bin/dry-run.rb cocoapods RuudPuts/DependatbotTest

A more complex one does raise errors though $ bin/dry-run.rb cocoapods RuudPuts/Down

I also haven't verified manually wether the applied changes where the correct ones or wether the updated Podfiles are valid.

Before merging you might want to check out the regex changes in file_updater.rb, mainly POD_CALL. Since it was defined with newlines to adhere to rubocop rules matching failed because of this extra whitespace, even tough /x was passed. I had to rewrite them to make it shorter and without newlines.

After this #2 can be merged as well, this PR is based of it.