search

jspecify / jspecify

An artifact of fully-specified annotations to power static-analysis checks, beginning with nullness analysis.
http://jspecify.org
Apache License 2.0
429 stars 26 forks source link

Compile the `samples` files as tests (samples-google-prototype-eisop) #498

Closed wmdietl closed 2 months ago

wmdietl commented 2 months ago

This is into the samples-google-prototype-eisop branch. Let me know if I should do something similar for main and/or samples-google-prototype.

wmdietl commented 2 months ago

I could see doing it for main (and then merging that into samples-google-prototype). Maybe it will help with the conformance-test scores there?

Doing it on main fails, because UnknownNullness isn't declared in that branch. Is it worth going through the samples and removing the failing tests? As we're rewriting the samples as conformance tests, I think that's not worth it.

I've created #501 as additional PR, to also compile the samples in the sister-branch samples-google-prototype.

cpovirk commented 2 months ago

Heh, oops. As soon as I saw that this thread had a new message on my phone, I suddenly realized my mistake about main :) I agree that it's not worth doing anything there.