jspenguin2017 / uBlockProtector

An anti-adblock defuser for Nano Adblocker and uBlock Origin
GNU General Public License v3.0
740 stars 83 forks source link

Violent monkey doesn't want to load ublock protector script #307

Closed Sheeraudacity closed 7 years ago

Sheeraudacity commented 7 years ago

I can't even install ublock protector, there's no image available since when I press the install now link nothing happens, well not nothing the tab's icon starts to shutter and the tab becomes unable to go to any other site. I tried both https://openuserjs.org/scripts/jspenguin2017/uBlock_Protector_Script and https://jspenguin2017.github.io/uBlockProtector/ ,hell I downloaded the usercript itself and dragged it to violent monkey settings tab, as you may have already figured out I have no idea how to use violent monkey I only downloaded it for u block protector because I'd rather use it than AAK cont, never had this much trouble with tampermonkey always downloaded easily but violentmonkey is a pain in the ass

jspenguin2017 commented 7 years ago

I'm aware that either the install link or Violentmonkey is bugged, but since Script is approaching end of life anyway, I won't be spending time fixing it. If you wish to use AAK-Cont, that's your freedom, but keep in mind that I won't be spending as much time maintaining AAK-Cont.

Sheeraudacity commented 7 years ago

I am pretty sure it's violent monkey I was able to download the script easily enough with tampermonkey, I'd rather not use AAK-cont can you tell me how to downloads scripts with violent monkey in general or anything that might interfere with that

jspenguin2017 commented 7 years ago

Try pasting this link to "Install from URL" box: https://github.com/jspenguin2017/uBlockProtector/raw/master/uBlockProtector.user.js

I don't really know why it's bugged, I just want to work on my extension instead of debugging Violentmonkey, so I can once for good replace those script hosts that I'm relying on.

Sheeraudacity commented 7 years ago

Thanks it worked perfectly, good luck with fixing the extension

jspenguin2017 commented 7 years ago

Don't close, so other people can see it...

Sheeraudacity commented 7 years ago

ooh my bad I thought that issues will remain in the issues tab even if closed and you should close an issue after it's been solved

uBlock-user commented 7 years ago

This is a regression bug in VM, nothing to do with the Script. With the release of v2.7.0, this bug was introduced.

uBlock-user commented 7 years ago

Okay many functions of VM are not working, looks like v2.7.0 is broken !

ghajini commented 7 years ago

@gera2ld fyi

uBlock-user commented 7 years ago

New bug report - https://github.com/violentmonkey/violentmonkey/issues/144

jspenguin2017 commented 7 years ago

Hopefully this fixes it, I expected Violentmonkey to say it's not valid or just ignore the click, not put page in a weird state. Anyway, I won't rush the extension as I want to do it right.

uBlock-user commented 7 years ago

Okay, it appears the issue seems to be stemming with this script only.

Piter432 commented 7 years ago

keep in mind that I won't be spending as much time maintaining AAK-Cont.

Does this mean that in the future the AAK-Cont will not be developed or what?

jspenguin2017 commented 7 years ago

@Piter432 Maybe, whatever happens to it, it will be better than the original AAK.

jspenguin2017 commented 7 years ago

@uBlock-user Can you check if b6489d4d687a7f4f824969a4018bc51240579e4a fixed it?

uBlock-user commented 7 years ago

@jspenguin2017 I removed the script and reinstalled it and the issue is still there.

Okay the installation issue seems to be gone, but script order and check for updates button doesn't work.

uBlock-user commented 7 years ago

Also I cannot disable the script in VM.

jspenguin2017 commented 7 years ago

@uBlock-user What issue? Not installing? That's not my problem, I already added @namespace. If null is not a valid namespace, then he must add doc somewhere, as I won't be digging into the issues. I think he screw something up when refactoring for Firefox, another reason to not support Firefox.

jspenguin2017 commented 7 years ago

Also I cannot disable the script in VM.

That has nothing to do with my code...

uBlock-user commented 7 years ago

https://github.com/violentmonkey/violentmonkey/issues/144#issuecomment-309832836

That's what he said

uBlock-user commented 7 years ago

Everything was working fine until today and VM just screwed up out of no-where.

uBlock-user commented 7 years ago

Still all of this is happening on this script only so I think VM is somehow conflicting with this script somewhere

jspenguin2017 commented 7 years ago

@uBlock-user OK, I don't care anymore, just let me finish coding the extension.

uBlock-user commented 7 years ago

@jspenguin2017 Sure, VM issues are not our responsibility anyway.

jspenguin2017 commented 7 years ago

The extension is released.