jspenguin2017 / uBlockProtector

An anti-adblock defuser for Nano Adblocker and uBlock Origin
GNU General Public License v3.0
744 stars 82 forks source link

gamestar.de #635

Closed Symbai closed 6 years ago

Symbai commented 6 years ago

Test link (required):

http://www.gamestar.de/videos/warcraft-4-wird-kein-handyspiel-video-talk-blizzards-ambitionierte-mobile-plaene,94583.html

Screenshot of the web page (required):

https://imgur.com/a/MNnTm

Screenshot of the console (press F12 to bring up the console) (required):

https://imgur.com/a/1Y9dH

Add everything else that you believe to be useful below (optional):

Since today videos are no longer playing as adblocker is detected. Video starts for about 1 second and then the player disappears and an adblocker message shows up (in screenshot the green/red bars).

uBlock-user commented 6 years ago

Already reported here #507

It appears it's no longer working.

uBlock-user commented 6 years ago
$(document).ready(function(){
--
  | setTimeout(function(){
  | if (typeof window.uabInject !== 'undefined' && window.uabInject === true) {
  | var iVideoId = 94583;
  | var sIframeSrc = '/_misc/glomex/gs/index.cfm';
  | var iNoTrack = 0;
  | jwplayer('playerID').remove();
  | $('#video-placeholder,#video-canvas').remove();
  | $('<div class="col-xs-12" style="margin-bottom:20px;padding:0px;"><iframe src="' + sIframeSrc + '?vid=' + iVideoId + '&notrack=' + iNoTrack + '" width="100%" height="620" scrolling="no" marginheight="0" allowfullscreen="true" marginwidth="0" frameborder="0"></iframe></div>').insertBefore( $('#socialshare') );
  | }
  | }, 3000);
  | });

gamestar.de##script:inject(abort-on-property-read.js, uabInject)

okiehsch commented 6 years ago

@uBlock-user this has also been reported here: https://gitlab.com/xuhaiyang1234/AAK-Cont/issues/280 I will add gamestar.de##script:inject(abort-on-property-read.js, uabInject) to uBO-filters

uBlock-user commented 6 years ago

FYI I used uabinject-defuser.js initially but that doesn't work here, you may need to modify that scriptlet.

okiehsch commented 6 years ago

gamestar.de##script:inject(uabinject-defuser.js) is already part of uBO-filters and still defuses the ad-reinsertion script it was designed for. I don't think there is any need, right now, to modify it, because your solution works just fine for this adblock-wall issue. Keeping in mind that I have to add your solution anyway, atleast for the moment, because of https://github.com/gorhill/uBlock/commit/126110c9a0a0630cd556f5cb215422296a961029

uBlock-user commented 6 years ago

Thanks for the info. I wasn't aware of the ad-reinsertion script, as I thought it was for anti-adblock.

I have to add your solution anyway, atleast for the moment, because of gorhill/uBlock@126110c

How long is that going to last ?

this applies only to the Firefox webext[-hybrid] version of uBO.

So pure webext version is excluded ?

okiehsch commented 6 years ago

No, all Firefox versions 1.14+ will have to wait until next release before they can use a newly added or modified scriptlet. That includes the dev-versions, so you will get regular access to new scriptlets if you use those, but the vast majority of Firefox users obviously only uses the stable version.

uBlock-user commented 6 years ago

No I meant how long this AMO drama will last. Are they always going to block this on the grounds of remote code execution from here on or is this just a temp. situation with them ?

okiehsch commented 6 years ago

It will be permanent, unless they change their policy, so I assume nothing will change, atleast in the foreseeable future.

jspenguin2017 commented 6 years ago

Looks like I was a bit late. Reverting c809da66ceb9f93693d4a6b78c7ee6e0dfae43b7

jspenguin2017 commented 6 years ago

Yea, Firefox store problems is also a reason why I keep hesitating in adding Firefox (58+) support, I planned on doing it for like 3 times, and every time failed with not able to automatically upload builds. Maybe I'll try Selenium Chrome Driver if Firefox 58 turns out to be really good, hopefully they don't have a Captcha.

jspenguin2017 commented 6 years ago

I don't think Chrome store formally allow remote code execution neither, but you can always have an auto-build pipeline to publish every commit.

uBlock-user commented 6 years ago

It's inclusive in their permission titled "Read and change all your data on all the websites you visit" from the beginning, that's why this won't ever happen with Chrome Store.

smed79 commented 5 years ago

@okiehsch ads are not blocked gamestar.de

okiehsch commented 5 years ago

Have you updated your filter list?

smed79 commented 5 years ago

Have you updated your filter list?

Fixed after my report (18:31) https://github.com/uBlockOrigin/uAssets/commit/13b264096883e4f478ebd4d155e65e0bf18640d5 (18:54) https://github.com/uBlockOrigin/uAssets/commit/82a1a94e5650fb639d939e5a9e2f1b218fc97824 (19:14)

jspenguin2017 commented 5 years ago

Please refrain from digging up years old threads. If there is a new problem, open a new issue.