search

jspenmar / slowtv_monodepth

Official repository for the ICCV2023 paper "Kick Back & Relax: Learning to Reconstruct the World by Watching SlowTV"
https://arxiv.org/abs/2307.10713
Other
82 stars 5 forks source link

Typo in get_mask in evaluator.py #7

Closed xapaxca closed 7 months ago

xapaxca commented 7 months ago

Hi Jaime,

Great job done!

I believe I've identified a typo in evaluator.py. It appears that the Eigen crop is applying the NYU mask, and vice versa, the NYU crop is applying the Eigen mask.

    def get_mask(self, target: ty.A) -> ty.A:
        """Helper to mask ground-truth depth based on the selected range and Eigen crop."""
        mask = target > self.min
        if self.max: mask &= target < self.max
        if self.use_eigen_crop: mask &= self._get_nyud_mask(target.shape)
        if self.use_nyud_crop: mask &= self._get_eigen_mask(target.shape)
        return mask

Thank you!

jspenmar commented 7 months ago

Fixed now! Thanks for pointing it out