jsplumb / community-edition

The community edition of jsPlumb, versions 1.x - 6.x
https://jsplumbtoolkit.com
Other
237 stars 22 forks source link

Endpoint doesn't follow mouse pointer when scrolling #79

Open MornMartin opened 2 years ago

MornMartin commented 2 years ago

Version:5.8.0 Description:

scroll-html

scroll-container

sporritt commented 2 years ago

@mornmartin can you try this in 5.9.0?

MornMartin commented 2 years ago

I tried in master branch (latestCommitId: accc57eb673af6962cabbb382a5aab2817a87334), this issue remains. In my case, i made some changes in file https://github.com/jsplumb/jsplumb/blob/master/demo/draggableConnectors/index.html.

  1. Modify the el's style as height: 300px;overflow: auto; whose className includes jtk-demo-main
  2. Decrease view height until the vertical scrollbar appears
  3. Drag a endpoint
  4. Scroll the mouse wheel
sporritt commented 2 years ago

thanks for checking. yes i can see how to reproduce the issue by hand but i'm interested in reproducing it in a unit test.

wangjingithub commented 2 years ago

how to deal with the question,thank you very much

sporritt commented 2 years ago

this PR contains a fix

https://github.com/jsplumb/jsplumb/pull/1139

but no unit tests. i'd really like first to isolate this with a failing unit test.

MornMartin commented 2 years ago

How can it be merged ? Should i write unit tests ?

jpech-tibco commented 1 year ago

@sporritt @MornMartin is there any way to build packages from source?

j4acks0n commented 1 year ago

@sporritt @MornMartin is there any way to build packages from source?

Idk Im Not Sure Too,But I Think No,Only The Way Is you install it from cmd then paste it in your folder