jspm / generator.jspm.io

8 stars 6 forks source link

(chore): bump @jspm/generators@1.1.10 #26

Closed JayaKrishnaNamburu closed 10 months ago

guybedford commented 10 months ago

Note that the generator version didn't actually bump here, because the import map is acting as a lock file.

JayaKrishnaNamburu commented 10 months ago

Ah Good catch, tried it in my very old fork where the generator was like 1.0.2 :D and thought the same would have been now. Will change the import-map too with the cli. So, the generates maps from the deployed project can take advantage of it too 👍

guybedford commented 10 months ago

If we upgrade this project to use the CLI that should fix the semantics here btw. Because the current chomp workflow doesn't behave the same as jspm install I think, which should do a bump.

JayaKrishnaNamburu commented 10 months ago

Yup, for now i am using cli to manually bump the import-map inside sandbox.html file. Will create a separate issue to adopt the cli for the project 👍. Waiting for the build to pass for the cdn

guybedford commented 10 months ago

@JayaKrishnaNamburu is the CLI bumping the generator version or no? Did you try jspm update?

JayaKrishnaNamburu commented 10 months ago

There are few observations here

guybedford commented 10 months ago

@JayaKrishnaNamburu the build server is a little backlogged at the moment, hopefully our new server will be up in the next month to alleviate the load. I've triggered the build for the generator, it should be available now.

jspm update checking only for imports seems correct to me. Perhaps we should reevaluate the import map here using the CLI so that it has the generator in imports?

JayaKrishnaNamburu commented 10 months ago

jspm update checking only for imports seems correct to me. Perhaps we should reevaluate the import map here using the CLI so that it has the generator in imports?

Yup, exactly when the project is going to adopt the cli by dropping the current way of import-maps generation using chomp task. We should change the map a little 👍