search

jspm / generator.jspm.io

8 stars 6 forks source link

Add ability to upload package.json and get a import-map #8

Closed JayaKrishnaNamburu closed 1 year ago

JayaKrishnaNamburu commented 1 year ago

Just a small usability improvements, upload package.json and create import-map. Makes it easy to convert existing ones. I always missed this, so adding it 😅

https://user-images.githubusercontent.com/11075561/224514557-5ff1fb7a-af53-4662-a665-2fcccf61d1c7.mov

guybedford commented 1 year ago

AHHH this is awesome!! Can you resolve the conflict? Then certainly let's get it landed alongside a generator update.

guybedford commented 1 year ago

Would be nice to possibly even support drag and drop of package.json.

guybedford commented 1 year ago

Could imagine putting the button at the bottom of dependencies with text next to it: [ ^ or drag a package.json file here]

JayaKrishnaNamburu commented 1 year ago

Done, added drag-drop support and then added a comment in the html content. Instead of moving around the UI

Screenshot 2023-03-12 at 12 31 28 Screenshot 2023-03-12 at 12 32 00
guybedford commented 1 year ago

Because the HTML is copied as part of the output, I think we should have the note as a separate UI element somehow, eg as small bar with the text at the bottom of dependencies pane.

guybedford commented 1 year ago

Maybe something like this -

image

JayaKrishnaNamburu commented 1 year ago

Should be good now 👍

JayaKrishnaNamburu commented 1 year ago
Screenshot 2023-03-13 at 16 03 22 Screenshot 2023-03-13 at 16 04 56
JayaKrishnaNamburu commented 1 year ago

@guybedford feel free to ping, if changing the drop-zone to somewhere else works best 👍

guybedford commented 1 year ago

@JayaKrishnaNamburu sorry for the delay, and thanks so much for iterating on this. Can we make the whole dependencies area the drop zone do you think?

JayaKrishnaNamburu commented 1 year ago

Yup, definitely possible. Will push that change too 👍. I too felt the dropzone is little too small