search

jspm / generator

JSPM Import Map Generator
Apache License 2.0
165 stars 21 forks source link

Top-level resolutions #172

Closed guybedford closed 1 year ago

guybedford commented 2 years ago

We need to ensure "resolutions" apply for top-level installs, these still seem to be getting missed somehow.

Bubblyworld commented 1 year ago

@guybedford Do you know/remember how to reproduce this? Setting "resolutions" on the generator options seems to work fine for me for top-level installs, secondary installs, and linking. For instance, this works:

let generator = new Generator({
  mapUrl: import.meta.url,
  env: ["production", "browser"],
  resolutions: {
    semver: "6.2.0",
  },
});

await generator.install("semver@latest");
let json = generator.getMap();
assert.ok(json.imports["semver"]);
assert.ok(json.imports["semver"].includes("6.2.0")); // passes fine
guybedford commented 1 year ago

Tests included, closing as resolved.