jspm / generator

JSPM Import Map Generator
Apache License 2.0
160 stars 20 forks source link

Preload URLs not rebased #277

Closed guybedford closed 1 year ago

guybedford commented 1 year ago

I just ran the JSPM generator updates and hit some bad preload URL injections:

<html>
<body>
<!--StartFragment-->

<link rel="modulepreload" href="file:///var/jspm/generator/src/api.js" integrity="sha384-+0A/uzmjeImNAWXWRc8bXfWjJ7knxA3ADQckGVfUKNyJ0b767AY/lty4ibLcNBOU" />
--
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/dependencies.js" integrity="sha384-vYLWmTRHa96ifozdcskONBTCcmquDaddfNnfdQJyae4gOrpP52ma54wrm8K10xH/" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/help.js" integrity="sha384-yrnrCIA+FRZadLb+0SteCSr/m9puRhq94E2sG97ckVPfcqGdLf2usVlciueg3ynG" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/mapapp.js" integrity="sha384-WIRASUrfOBXXH3kr/I10zXGXSZ41tyNaCv93XpZzsrPkovyQPN/vK8Ge50KenT66" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/popup.js" integrity="sha384-Ll4Kt2YDaGYi/X02OGxM9+J+I942EDdOYxaVx43nFt2wfSHpnnWiHwZ43RkbCMsA" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/progress.js" integrity="sha384-5fPEG5cu2BN1BcBbsGEybmm2IQ/wwZhl0cgGMyW//6Fj7e78dfZKkNEvWLrP6T55" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/select.js" integrity="sha384-yROtkvmqMubW+DvUczrE5N31/jwcQVMaSlZnPFTpnOyfZ3vR9tLqaPYzXyo55RL5" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/statehash.js" integrity="sha384-NwU1Nj9jRLATqQEwtNmIqcOFIxP6pqkclx8vIFbGogo6qqiokERWBC+RtYNdldjA" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/toast.js" integrity="sha384-z3n1cs19aXuuqxkND1Tc2n1TBW3/J+lganH0MjyBSlIyov733cX/IGdJveTvS/vM" />
  | <link rel="modulepreload" href="file:///var/jspm/generator/src/utils.js" integrity="sha384-Vy61yAHdbCyCOGpChmr6Kc0IwwOZhawDhwsxRdFGrZumhKWnV8GF7c7yIZqQCLSR" />

<!--EndFragment-->
</body>
</html>

For the workflow in https://github.com/jspm/generator.jspm.io/blob/main/chompfile.toml#L46.

It seems the local base relative rebasing isn't being apply to the preload injections.

Note this workflow should also be checked against the new CLI version of the command that it should ideally upgrade to.