search

jspm / github

Github Location Service
16 stars 43 forks source link

Set proxy in "request()" calls (?) #78

Closed subesokun closed 8 years ago

subesokun commented 8 years ago

Since recently I'm faced with a corporate firewall which behaves very strange from time to time. So far JSPM worked for me when setting the HTTP(S)_PROXY environment variables but today for some reason the request module has ignored this proxy setting. First by manually adding the proxy option in the github.js like

request({ proxy: 'http://...', ... })

I came through the proxy. If I didn't set this option I ran always into a registry timeout. Do you think that it makes sense to read out the proxy environment variables and if set pass them into the request call?

guybedford commented 8 years ago

Better information flow here could well be worth it, by storing relevent proxy information in the ~/.jspm/config file and pipeing it all through. If you're able to provide a PR along these lines it would be much appreciated.