search

jspm / github

Github Location Service
16 stars 43 forks source link

Immediate uninstall if repository casing is mismatched #93

Open letmaik opened 8 years ago

letmaik commented 8 years ago

If you do jspm install github:alice-and-bob/have-fun where the username is actually called Alice-and-Bob then jspm happily installs the package but one step after doing so removes the "package configuration" again.

guybedford commented 8 years ago

Is this with jspm 0.16 or jspm 0.17?

guybedford commented 8 years ago

Also see https://github.com/jspm/jspm-cli/issues/1274.

letmaik commented 8 years ago

That's 0.16.

adamburgess commented 8 years ago

This also happens for .17 (I recently renamed my github and had to do a hard delete and jspm install to fix it)

guybedford commented 8 years ago

I guess the simple thing to do here is just to add a toLowerCase on the comparison filter in the clean method after installing. But casing in general is still pretty badly handled...

guybedford commented 8 years ago

Odd I can't seem to recreate this now... I just tried jspm install github:components/classlist.js in both 0.16 and 0.17 and it didn't seem to remove it in either.

adamburgess commented 8 years ago

My issue was the username -- AdamBurgess to adamburgess.

Also, it was on Windows, ie case insensitive. Not sure if that makes a difference or not. I'll test again shortly

guybedford commented 8 years ago

Help replicating here would still be appreciated.

guybedford commented 8 years ago

(or did we fix this casing stuff already?)

adamburgess commented 8 years ago

@guybedford I've just retried this on .17 beta 28 and .16 latest and it's fixed for me, though installing something like AdamBurgess/x is saved as AdamBurgess/x, not the "correct" adamburgess/x

maybe this would be fixed with https://github.com/jspm/github/issues/54 ?

guybedford commented 8 years ago

@adamburgess yes casing adjustments should be treated as a redirect actually, which should be relatively straightforward to add.