search

jspm / jspm-cli

ES Module Package Manager
https://jspm.org
Apache License 2.0
3.79k stars 272 forks source link

GitHub packages support #2497

Closed guybedford closed 1 year ago

guybedford commented 5 years ago

It would be worthwhile to support GitHub packages at this point as its own registry.

Either ghp: or gpr: I forget which is the preferred abbreviation for it at the moment.

It's relatively straightforward to put this together, it's simply a matter that I don't personally have any good reason to need to do this yet.

If anyone is specifically interested in this feature please say so.

fusionstrings commented 5 years ago

I would like to have it. Not for me specifically but for community. If you may guide me how, I would like to land a PR.

guybedford commented 5 years ago

@fusionstrings a contribution here would be absolutely amazing, and it is certainly something I'd be very grateful if you could work on.

The model to follow would likely be the existing npm / GitHub registries - https://github.com/jspm/npm/blob/master/npm.js / https://github.com/jspm/github/blob/master/github.js.

The registry calls are done by returning an object, which provides an expected class constructor and class methods signatures.

It may also help to see the other side where these calls are made, which is all in the registry manager file at https://github.com/jspm/jspm-cli/blob/master/src/install/registry-manager.ts#L308.

If it would help you to work on this after ensuring the registry API is fully documented I'd be happy to try flesh that out with you too.

fusionstrings commented 5 years ago

Thanks a lot for guidance. I am gonna start with it and will ask questions if I will have any. :)