jspm / jspm-cli

ES Module Package Manager
https://jspm.org
Apache License 2.0
3.79k stars 272 forks source link

Fix install scoped package with binaries #2512

Closed jbanety closed 1 year ago

jbanety commented 4 years ago

When I install a scoped package with binaries I'll get this error :

$ jspm install  @mapbox/geojson-rewind
err (jspm) Internal Error: Unhandled promise rejection.
Error: ENOENT: no such file or directory, open '[...]/jspm_packages/.bin/@mapbox/geojson-rewind'

jspm install command don't stripe scope in path so the destination folder doesn't exists. My PR is to remove the scope with a regexp before writing file.

guybedford commented 4 years ago

Thanks for the PR. This is originally generated in https://github.com/jspm/jspm-cli/blob/master/src/install/package.ts#L449 so I think we should add the scope check there, which is simply then name[0] === '@' ? name.slice(name.indexOf('/')) : name or something along those lines.

Just to warn you, due to a lack of user interest in jspm 2, the entire version is considered deprecated and will be abandoned soon.

jbanety commented 4 years ago

Hi @guybedford, I'm sad to hear that. It was very promising for the future of web app. What will be the alternatives?

guybedford commented 4 years ago

I'm working on a jspm 3 version which will entirely move away from trying to recreate local package management, since it seems that combination of approach is too complex for most users to grasp.

jbanety commented 4 years ago

How Can I help you?

Le ven. 27 mars 2020 à 17:38, Guy Bedford notifications@github.com a écrit :

I'm working on a jspm 3 version which will entirely move away from trying to recreate local package management, since it seems that combination of approach is too complex for most users to grasp.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jspm/jspm-cli/pull/2512#issuecomment-605100331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIBUYTGFRIUTJ4NU6K6QYLRJTJBXANCNFSM4LTHKANQ .

guybedford commented 4 years ago

If you're interested in trying out / contributing to jspm 3, it should be ready for further testing within the next month.

jbanety commented 4 years ago

👍 I have an internal project on which I will work during covid-19 confinment.

Le ven. 27 mars 2020 à 18:42, Guy Bedford notifications@github.com a écrit :

If you're interested in trying out / contributing to jspm 3, it should be ready for further testing within the next month.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jspm/jspm-cli/pull/2512#issuecomment-605148613, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIBUYWYL6CZWWVFIZWEHU3RJTQR3ANCNFSM4LTHKANQ .

fusionstrings commented 4 years ago

What are the ways one can be part of JSPMv3 testing, once and when it's available @guybedford .

guybedford commented 4 years ago

@jbanety @fusionstrings I can invite you both to the private testing for jspm 3 when it is ready if you like.

jbanety commented 4 years ago

👍 happy to help

fusionstrings commented 4 years ago

@jbanety @fusionstrings I can invite you both to the private testing for jspm 3 when it is ready if you like.

I will feel extremely privileged @guybedford 👍 .