search

jspm / npm

NPM Location Service
19 stars 34 forks source link

Fixed jspm/npm#101: mathcing more dependency formats for npm #109

Closed vadimpopa closed 8 years ago

vadimpopa commented 8 years ago

Fixed jspm/npm#101: mathcing more dependency formats for pm. Regex unit tests here: https://regex101.com/r/dS1fJ6/3

vadimpopa commented 8 years ago

Just noticed #96, so consider to close it because of this and because some formats will pass the reg-ex here, but will still fail in processPackageConfig - which probably is fixed in #96.

guybedford commented 8 years ago

Yes this is resolved properly in #96 with https://github.com/jspm/npm/pull/96/files#diff-59adaa9915a15ff8ed1f21fd655d5378R374 and https://github.com/jspm/npm/pull/96/files#diff-59adaa9915a15ff8ed1f21fd655d5378L256, but if you are interested in backporting to this release I'd consider including it.