search

jspm / npm

NPM Location Service
19 stars 31 forks source link

Refactor custom scope authentication #146

Closed glen-84 closed 8 years ago

glen-84 commented 8 years ago

The download method wasn't working. I really don't know how this worked before.

I decided to do some refactoring as well, and introduced a registryInfo method similar to what you described.

Please let me know what you think.

guybedford commented 8 years ago

@glen-84 thanks for this. Can you explain why the download method wasn't working here?

glen-84 commented 8 years ago

Well, it was always using self.auth (when appropriate), so it never would have sent the scope-specific auth. I was getting a 401 on the download for my scoped package.

Also, it would probably have been using the wrong registry URL (not scope-specific).

guybedford commented 8 years ago

Sure, thanks, I will try it out here.

glen-84 commented 8 years ago

@guybedford How's it looking?

glen-84 commented 8 years ago

@guybedford Will there be a release soon?

guybedford commented 8 years ago

@glen-84 sure I've posted this out now.