search

jspm / project

Roadmap and management repo for the jspm project
161 stars 8 forks source link

Can't import react-admin #113

Closed NewName closed 3 years ago

NewName commented 3 years ago

Importing the react-admin package,

import reactAdmin from 'https://jspm.dev/react-admin';,

gives a number of errors due to the @material-ui/icons@4 package, as react-admin seems to directly import various files in this package, eg one is resolved to https://jspm.dev/npm:@material-ui/icons@4/RemoveRedEye!cjs.

The main error is that these files seem to be served with the application/octet-stream encoding, but reading the encoding shows that it's actually a 404.

These files do seem to be accessible, but can only be found by changing the package version either to the full version number, eg https://jspm.dev/npm:@material-ui/icons@4.11.2/RemoveRedEye!cjs, or removing it altogether, eg https://jspm.dev/npm:@material-ui/icons/RemoveRedEye!cjs.

Example below: https://jspm.org/sandbox#H4sIAAAAAAAAAz2QS04EIRBA93OKks1sbIk7o9CJCy/gDRBq0mUoIFDzu/00EF0RUsV7L5inkL3cC8ImHNeD+TvQhfUAYBjFgd9cbShWneW0vKkxEJKI6zc6L/AZmBJ83RyXiEbP0f/r5BituhBeS66iwOckmHbalYJsNuCFPC7j8gyUSMjFpXkX0b7uLqNnjPnJ4d6pHdx8pSLQy63iHM4RRxYAcbdA7WGz61Qzw3ETKe1d699W+GV36rGxuL5y/OhMPaHdOFW7efzGA9QBbuolAQAA

In addition, the react-admin package seems to fail in the generator: https://generator.jspm.io/#U2VhYGBkDM0rySzJSU1hKEpNTC7RTUzJzcxzMNYzNNczAAC3zRQFIQA

guybedford commented 3 years ago

Thanks for posting. This is a bug in the serving process, I'm looking into it.

guybedford commented 3 years ago

To update I'm still looking into this - the package is just so big it literally takes 10 minutes to process so debugging is slow.

guybedford commented 3 years ago

The generator fix has been merged at https://github.com/jspm/overrides/pull/7, this should get the import map version working once the build completes shortly.

The jspm.dev issue is a file limit issue because there are 22000 files. I'm looking into the exact bottleneck.

guybedford commented 3 years ago

import('https://jspm.dev/react-admin').then(x => console.log(x)) is now working.

The version in JSPM generator is still pending some override fixes which I'm still looking into.

guybedford commented 3 years ago

The generator version is now working as well. Thanks again for posting.