search

jspm / project

Roadmap and management repo for the jspm project
161 stars 8 forks source link

generator.jspm.io produces outdated es-module-shims import (1.5.1) #259

Closed zachsa closed 1 year ago

zachsa commented 1 year ago

https://generator.jspm.io/#U2NhYGBkDM0rySzJSU1hqEosKnIw0DPTMwQArVL7dRkA

Bubblyworld commented 1 year ago

Seems to be hardcoded into the app: https://github.com/jspm/generator.jspm.io/blob/main/src/api.js#L32 Probably the page should be using the generator.injectHtml API which automatically does latest lookup for the shim.

JayaKrishnaNamburu commented 1 year ago

Did some hacky way in the recent vite-plugin-jspm to solve this thing https://github.com/jspm/vite-plugin-jspm/blob/main/plugin/src/index.ts#L16

guybedford commented 1 year ago

There is in fact a PR to update the generator site to use the new CLI in https://github.com/jspm/generator.jspm.io/pull/6. I'm not sure if that PR handles ensuring es-module-shims is always updated.

guybedford commented 1 year ago

But a generator bump should be done certainly there!

guybedford commented 1 year ago

This should be resolved now with the auto update system in place.