Problem with @google-cloud/bigquery import

laughedelic commented 3 years ago

Trying to import @google-cloud/bigquery (from Deno, but also in the sandbox)

import { BigQuery } from 'https://jspm.dev/@google-cloud/bigquery';

results in

error: Uncaught SyntaxError: The requested module '/npm:uuid@8!cjs' does not provide an export named 'default'
import _uuid from '/npm:uuid@8!cjs';
       ~~~~~
    at <anonymous> (https://jspm.dev/npm:teeny-request@7.0.1!cjs:3:8)

Could you explain what this error means and if it's possible to work around it?

guybedford commented 3 years ago

This is because a parent dependency is doing something like:

import uuid from 'uuid';

which is importing the default export.

This module is being loaded from https://jspm.dev/npm:uuid@8!cjs, where you can see it exports from https://jspm.dev/npm:uuid@8.3.2!cjs. Looking at that file in turn we can see that it is an ES module without any default export.

The !cjs in the URL means that it is supposed to pick the "require" variant of the "exports" condition.

The exports definition of uuid is in https://unpkg.com/uuid@8.3.2/package.json, and shows the exports field:

"exports": {
    ".": {
      "node": {
        "module": "./dist/esm-node/index.js",
        "require": "./dist/index.js",
        "import": "./wrapper.mjs"
      },
      "default": "./dist/esm-browser/index.js"
    },
    "./package.json": "./package.json"
  },

What this means is that the "require" - or the CommonJS version with the default export, is only loaded in Node.js. As a result jspm is loading the "default" export above which corresponds to an ES module which does not have a default export.

So this is a misconfiguration in the UUID package.

guybedford commented 3 years ago

Posted https://github.com/uuidjs/uuid/issues/561.

TrySound commented 3 years ago

I'm not sure "fixing" uuid will make the package work with deno. UUID browser entry point uses webcrypto which is not supported by deno. https://github.com/jspm/project/issues/93 So the problem is that jspm does not bundle for node.

guybedford commented 3 years ago

Agreed web crypto would need to be polyfilled as well for the Deno support, but that doesn't change the nature of the browser / node API discontinuity in play which will still affect browser users.

laughedelic commented 3 years ago

@guybedford Thanks for the context! Is there anything I can do to help with fixing this or can I temporarily work around this issue in my code? Also, I'm not sure what you're saying about web crypto. Is it some node dependency that has to be substituted because it doesn't work on Deno?

guybedford commented 3 years ago

@laughedelic standard procedure here is to ask the person filing the bug to submit a PR to the original repo. It sounds like @TrySound might be on it, but otherwise I would suggest creating a PR extending the exports field to include the correct entry point for uuid.

If this PR upstreaming process fails or hits a road block then we do have the JSPM overrides service at https://github.com/jspm/overrides to merge this package.json adjustment as an explicit override configuration but that should only be considered a last resort if the standard upstreaming process fails as it effectively creates a fork.

For local workarounds you should be able to apply an import map to remap the UUID entry point appropriately, using a configuration something like:

<script type="importmap">
{
  "imports": {
    "https://jspm.dev/npm:uuid@8!cjs": "https://unpkg.com/uuid@8.3.2/dist/index.js"
  }
}
</script>

I can't personally drive all these changes though so have to rely on maintainers / users to be receptive to the process here. Wil work on better communicating this process.

laughedelic commented 3 years ago

Thanks for the guidance! I will try to submit a fix to uuid repo (UPD: https://github.com/uuidjs/uuid/pull/563).

I also tried using import map, but hit the

error: Unmapped bare specifier "crypto"

which, I guess, was expected. I tried also adding "crypto": "https://jspm.dev/@peculiar/webcrypto" to the import map, but that gives me

error: Import 'https://jspm.dev/npm:pvutils@latest!cjs' failed: 404 Not Found
    at https://jspm.dev/npm:asn1js@2!cjs:1:0

And if I try to point it to a concrete version instead of latest: "https://jspm.dev/npm:pvutils@latest!cjs": "https://jspm.dev/npm:pvutils@1.0.17!cjs", it gives me the original

error: Uncaught SyntaxError: The requested module '/npm:uuid@8!cjs' does not provide an export named 'default'
import _uuid from '/npm:uuid@8!cjs';
       ~~~~~
    at <anonymous> (https://jspm.dev/npm:teeny-request@7.0.1!cjs:3:8)

guybedford commented 3 years ago

@laughedelic nice to see you digging into it here further and thanks for sharing and posting that PR. Just looks like you need to fix the trailing comma for the CI.

And if I try to point it to a concrete version instead of latest: "https://jspm.dev/npm:pvutils@latest!cjs": "https://jspm.dev/npm:pvutils@1.0.17!cjs", it gives me the original

This actually sounds to me like a bug in Deno import maps support as that module shouldn't be loaded at all if it is being explicitly mapped. They've been working a bit on the implementation recently - make sure you are using the latest version.

Not sure if you saw, but the latest CDN for import maps was just released at https://jspm.org/import-map-cdn. You might have an easier time with the import map customization with the generator tool there against the ga.jspm.io import maps CDN.

guybedford commented 2 years ago

I justed tested out the @google-cloud/bigquery import again on the latest import map generator, and it seems to be working correctly afaict:

https://jspm.org/sandbox#H4sIAAAAAAAAA61aW5PbthV+969A1JekNUnd9mJn1yMncTLNZDNuN26nTx6IhCTskgQXAKWVO/nvPbhIK1LgoTzVg60l8eE7BwfAuYC4+SYTqd5WjKx0kb97dbP7YTR794qQm4JpStIVlYrp20GtF9H1wDZornP27lNpf7ObxD3vu5S0YLeDNWebSkg9IKkoNSuBYsMzvbrN2JqnLLIPrwkvueY0j1RKc3Y7AgE3idPgZi6yrWX9Jorgh5Bf7z/ekV9YySTVQpK/F4af3NHKtn7IuCaf/vnbWxiPrtTbJFnuoPGDqoqYi+Qvn8a/r/7zyw+PP90N5fb+y6/3n0ar9MPDxy/D5ON99q/fv6jH9R/Zzx+3j5v1bx+G+qn8x2b0x91w+HD3/v3P02W2Eer9e5AXRVY1lUpeaWLMeDvgVqGCVtZM/7Va+Zdq8Na/gFezpRDLnEVpLuosmfPlU83kFhCDveZ0r3JZFW/DHWYX8WgcD5N5zfMsUTJNeJmxZ+g5sJL+fO00UKmoWEOBgJiD5iMNU1EUojxZPwefTeLRMKzd6y5BFV3y0kzYybL2PUDcML76OmlSPLBU88Xppn/pMhvHo68dnRQFV18pzvUAacN42idNC6FpnoM9WCLKlGFy2lgrYZhkXOkgOYXNpKM5VRjrC2h2CXRjR9elL31YY1wPayCBBX6Z5HyewONxd9si2UIlD0qU4ENWrKBRJulCR8PL2Lw8XQLO0xYuJT6RDmCtOgqPXpUjrD80z8CEXrkwg2LgX5FJNg+wHaWf3WgO7jkej5NSZAxYVTKXYgMkiaMK8kdVXitU0T1qNrJrKEy2UZHiy3KMUe0wMPArIAoOeqOmOMUU1BgZq5u/W73N0rycRg/YgPYY4LnomLx5KrcVDHr+mC0wqgOYNc44zMaXMa6SBZjFCvp4dLN/WRdzJntZ9rDZG6tNo+chY71YMNQLn7y0HFWQP2JPNYR+yA+UpuA4NC8w79Ldydo2PFMpzGbOFGaXHQRWnY2nQZoVeN7P4I9TnOt0uzQY29JEMeclyyKlJaMFpnsTaQ1xbT3GruWzazmSIFlUa55HHDXNAcwvYMNt3rQJzUoX57GMpWrxZ2xeLxF62z6bxhMIkybgeLIjlpxuT7FrE+gdmxm6bwhbNaurnD3jgWGPAWVHHQ6BpSn4nzkWvHYQs2h7WKzeLD2dzOGP2DJFjXuOFkIWVGvUPwTQbpOO7OwEmtviyiwSi/6JauBAxBTmP2iMEouU0AqrsmvzszW0n2fXO6o2/zPURxmmngXYFLdjqp+1qiQvNRaNXkBgp4lfzy8vW5QLqnSUMVY5h4vwtpAm8Y8nQTUt0qVYms4hzYVp4+US3zDdnXwO3ilJw+AiVqYiA3yfhAbYrtVJYt7FBW8nf7BmYR5lZNNdjPcQB3vrsiNGmT0QZVRTnMthYNATUM3MXdjHLc6zUhftVbqkz1xg3A5gffCkp1RZplVkzgp6Bn0Is7yjPl5XPdFaryIYjaRoWR1Az67i0fRUMdVoHFUM805NoN0ZfVXcUotHhnl+B4Dif2ISOJRrRaUvZhC+F5CvAbvqDQNc05xnPRV6A2cOKeILy+mqWdZmBZKzLFhDEOCOQOzztnevtqGgN1oPW7wpVqiuJZa1NoHgWMaYiQ3H2azR3sH23VfYQx0ZZNRtEF6umORomNxB/GnG7vFz2I+hiSmkoxMbw4KqqP68YY9BSnTAmIO9DGp5ivmRBs7nimG+E9TyWvm0TgXzzJ7ccJ/KhYdlYylUfhxdAAcoZEgH5yV9XN7HwMz7DeB9RNshHB7BaEkhgKJnTiG4FYIMfp9BRIou+skbaL8P9i+P+CGbwmbYAWym6jJt96JNs0Htudn56uAQN9jOgVYIpV19c1lHKQVrIgx7jD3kC/MUUJVH2Rxh8QhzyNKVd1uI2VnYeF5ANh2cXISpUArXNZxal+w8R2zA02YGSLRgOl0hAl5AIODSnHAHnaWDCbnEJu4FZAuAUWcYEjYlMkELYXsBwXZ70zGFPcfQ9uR5ZD2C+bPd+TyhULTjIBQqazz6eQRslK61WUULXtI8x+LCHoM40MoeYIka18ZjIOZ16kM1toxOt5YhanMzact0mKGoFBtM0ybSF2g2+Wu2tCWc8WDNc5ncJatTzY/O7iuFVbPQCtN13WXmutxCiYh+WjldU0/WkvGE2eHJHANf+AIwpKH9NOii01mUPOBrSYLEJNsV5HhW00LCMobIkezfhl1aq5MfsGYStlTi3qlkATVFjJ56h2V3kv0/yrzkamdRx/12KgQTozCv4REwv9fXHbFNMi230SlUBzjrFMN8Jj+Ker8dHKAgmRp3JGoGJU8j28F8FLev2mxqVT1iNKbdfDi6Qqqz3nV++q4KpvV+wnuPGxs4G1vCSY/HqRVfYLN7CEO+pDgf8DljxmWd59tQk/JIXj3HrQDt9kw07Ko1Y+Upi7uBm13FHVcqDpnz80Qq4Gkzi3q5ilIhHjkWYg5hIOTCr1n3ok1ZlyXLe+v9Q5g9quww6oYxXdIUi6B7jKlBp7A2zd+ROWRtkdWS459iHQAcznR38sDURQJvY8iqjsgwnU6fFOBpM2t+Jurjz2b221rGKslSqIQxUzSA/ltcODTUNcc+Jpjm2bU9PfQm3ceY4JQbvLsgUfZ8prbMk319D/iO4GUp19h3/AOqdfsjPpT4Ej2AdAB3DcAfNdg3LZ6NpFWF5e8O4G3tHloUW1iHHPUuHuFLbv/UYvkCKp5lgRmieHf9i5A/X+3+N/9uEndZzdxNe+Vu1ZEP9+QOsuSckfsVL9Tb3Z26glaKVCLfLnieE0jcSWFhinhRimy4XkFJQvhBD1VX9uFbGCZhzymrNPlxBVkVI9dv/vZd69IcVdsyJeBkbzu/WKnIyTXBqdhdyPCrttFkRk1SKZQS0pxZ3Q5oKcptIWo1eNceeePSnmOxN/bIbjB/Bd3Ij+YK1g/+rh0xuWHnzb3vHTEhSUL+LblmYA5eepsRE9zIikn2moAhgZkSxSoqYR8TsC+zpoSXAzDFgFANQXFeQ5soiV6xHYtTOrZizOUHkbM4F8tvG2p+931jom8Sd4fyJnF3O/8Hh3vSxvMpAAA=

jspm / project

Problem with @google-cloud/bigquery import #93