search

jspm / registry

The jspm registry and package.json override service
https://jspm.io
229 stars 255 forks source link

Migrates jquery-ui to npm package #1009

Closed gsmith85 closed 7 years ago

gsmith85 commented 7 years ago

jquery-ui has been updated in the regristry to point to npm:jquery-ui instead of github:components/jqueryui.

Further, package-overrides that pointed at the github:components version of both jquery-ui and jquery have been updated to rely on the npm version of the package.

Fixes #1008

guybedford commented 7 years ago

@aluanhaddad do have any link to further details here? This is a risky change because it will potentially break things for a lot of users, but it would be nice to consolidate on the npm version of jQuery definitely... we just need to be sure it will be a stable change first.

aluanhaddad commented 7 years ago

@guybedford Unfortunately I don't have links to specific issues. Upon further reflection I would say it is probably better to leave packages that are not related to jquery-ui out of this PR and revisit them on a case by case basis.

gsmith85 commented 7 years ago

My take is this:

  1. github:components/jquery is basically asking for the latest version of jQuery per the components shim. I think in this case there is very very low risk to simply swapping in npm:jquery.
  2. Specific versions of jQuery are the bigger risk and primarily older versions that may not have a package.json. But taking a second pass only knockout-sortable@0.12.0.json falls into this category and uses @^2.1.4 which will match 2.2.4 which looks good to go.

But your call. I certainly don't want to hose a bunch of other dependencies, just trying to be a good citizen and leave things better than I found them!

gsmith85 commented 7 years ago

Okay so I'm going to revert all components/jqueryui@<some-version>.json and otherwise it look like we're good. I'll kick those changes up in short order.

aluanhaddad commented 7 years ago

@gsmith85 thank you, very much appreciated!

@guybedford this looks good, but if you could a last look through this that would be great.

guybedford commented 7 years ago

LGTM