search

jspm / registry

The jspm registry and package.json override service
https://jspm.io
229 stars 256 forks source link

Fix angular-ui-router@0.3.1 override #1019

Closed joeldenning closed 7 years ago

joeldenning commented 7 years ago

See https://github.com/jspm/jspm-cli/pull/2200 and https://github.com/jspm/jspm-cli/issues/2197#issuecomment-269520408 for discussion. The .js extension should not be included in shim configurations.

I have tested this by doing jspm install angular-ui-router@0.3.1 -o '{"main": "release/angular-ui-router.js", "shim": {"release/angular-ui-router": {"deps": ["angular"]}},"dependencies": {"angular": "*"}}' locally and verified that it works. Without this change, ui-router@0.3.1 does not work in jspm@0.17