search

jspm / registry

The jspm registry and package.json override service
https://jspm.io
229 stars 256 forks source link

add override for tslib to use module entry point #1040

Closed frankwallis closed 7 years ago

frankwallis commented 7 years ago

Currently trying to use importHelpers option throws an error due to importing named exports from commonjs, see https://github.com/frankwallis/plugin-typescript/issues/199

aluanhaddad commented 7 years ago

@frankwallis I was playing around with this last night and ran into the same issues. I used the same override locally that you have added here and it works great. Thanks for submitting this!

AdamWillden commented 7 years ago

This change broke our builds today. We transpile as a build step rather than on the fly. As a result of this PR it was trying to load ESM rather than cjs and failing to do so (due to our transpiler set to false). I had to re-override this change which was quite frustrating waste of time for us figuring out what went wrong.

timfish commented 7 years ago

@AdamWillden how did you re-override this issue?

AdamWillden commented 7 years ago

@timfish Not at computer at moment. I modified the entry added to package json. Removed the 'main' line and changed the 'format' line to 'cjs'

frankwallis commented 7 years ago

I have created https://github.com/jspm/registry/pull/1041 to resolve this.