search

jspm / registry

The jspm registry and package.json override service
https://jspm.io
229 stars 255 forks source link

Esprima does not need the `fs` and `process` shims #845

Closed hmalphettes closed 8 years ago

hmalphettes commented 8 years ago

It is standalone and packaged as a UMD.

Fixes https://github.com/jspm/registry/issues/839 Reference: https://github.com/jquery/esprima/issues/1486

guybedford commented 8 years ago

It would also be worth posting a PR like this to the jspm registry to get something in for the older versions. The check-in here is still preferred as it avoids having to store this config in the local package.json of every users' project that uses Esprima.

hmalphettes commented 8 years ago

@guybedford I apologise for taking time to understand how to improve on this PR. I read as much as I could the content of the jspm/registry but I am missing how to add support for older versions of esprima nicely. Can you give me another hint or example to make this happen? Thanks!

guybedford commented 8 years ago

@hmalphettes my apologies I incorrectly read this as an Esprima project PR, so was suggesting you do a PR here. Let me know if it all works out ok.

hmalphettes commented 8 years ago

No problem. Many thanks again for this and everything around jspm/systemjs.