Closed jakeNiemiec closed 8 years ago
We can't change the existing github override because that would be a breaking change. Rather approach we can make to not force a breaking path is to make npm:bootstrap
version work as the main repo for bootstrap in jspm and change to that.
What exactly is not working with npm:bootstrap? What is the error? Let's fix it.
@guybedford It is broken right now, bootstrap@4.0.0-alpha.2
requires jquery below 3.0.0.
Using this as an example https://github.com/jakeNiemiec/jspm_bootstrap .
For this example we are simply importing bootstrap https://github.com/jakeNiemiec/jspm_bootstrap/blob/master/src/index.js#L2
Everything loaded. Notice that jquery was properly included on the page, and exported within bootstrap.
jspm i npm:bootstrap@4.0.0-alpha.2
Jquery no longer gets properly exported, it is loaded on the page after index.js executes (this is beyond the scope of my understanding).
jspm i jquery
😞 same error
This is due (in part) to "github:twbs/bootstrap@4.0.0-alpha.2" > "dependencies" > "jquery": "*",
SO question reporting this problem http://stackoverflow.com/q/37823898/6091685
@jakeNiemiec thanks I've updated the Bootstrap override so that it uses jquery 2! It seems the jquery update broke a lot of packages (potentially all the places we have jquery: '*'
actually). We did that to support jquery 1 and 2 at the same time, but it seems that has backfired. I'm wondering if it is worth just going through and bulk updating all jquery: '*'
overrides to jquery: '2'
...
For Bootstrap, you're points are completely valid, but I've just made too many breaking override changes in the past and it's not fun breaking peoples' projects. So I'd really appreciated if we can focus on getting the npm override to work.
Test using this repo: https://github.com/jakeNiemiec/jspm_bootstrap