search

jspm / registry

The jspm registry and package.json override service
https://jspm.io
229 stars 256 forks source link

Bootstrap 3.3.7 supports jQuery 3 #952

Closed BBosman closed 7 years ago

BBosman commented 7 years ago

Bootstrap 3.3.7 jQuery requirements: Bootstrap's JavaScript requires jQuery version 1.9.1 or higher, but lower than version 4.

BBosman commented 7 years ago

I've updated the PR based on your suggestion.

I'm wondering why jspm wouldn't understand >=1.9.1 <4 as given version format though, as it's a valid semver range according to the docs?

guybedford commented 7 years ago

Thanks for the update.

BBosman commented 7 years ago

I made a literal copy of bootstrap@3.3.6.json in the same directory for this PR and only modified the jquery dependency.

I don't mind making the requested changes, but don't the other files need those changes as well?

guybedford commented 7 years ago

Ah I missed that. The files we can get away with, but not having the systemjs property is critical for jspm 0.16 support.

If you add this, that should be fine for future versions now.

BBosman commented 7 years ago

I've updated the PR.

I also dropped the files, as a quick glance at the bootstrap packages.json showed that it was out of sync anyway.

guybedford commented 7 years ago

Excellent thanks so much for your efforts here.